From 710b532d5a3691f8fd13157a08277aa2a3753a06 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Sat, 14 Nov 2015 17:28:25 -0800 Subject: [PATCH] Don't "preview" (i.e. execute) user JS on non-preview requests If you edit your user JS page, change the JS, and click Show preview, the new JS will be loaded ("previewed"). However, this "preview" is also engaged when you click Show changes, or click "Save page" and fail to save. Don't do that: only "preview" JS when the user has actually chosen to preview it. Change-Id: Id9bcd235d3414b68de6e5d491b7b0c4f9b16e05f --- includes/OutputPage.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/includes/OutputPage.php b/includes/OutputPage.php index 81724c5cd8..c35204d604 100644 --- a/includes/OutputPage.php +++ b/includes/OutputPage.php @@ -3309,7 +3309,11 @@ class OutputPage extends ContextSource { */ public function userCanPreview() { $request = $this->getRequest(); - if ( $request->getVal( 'action' ) !== 'submit' || !$request->wasPosted() ) { + if ( + $request->getVal( 'action' ) !== 'submit' || + !$request->getCheck( 'wpPreview' ) || + !$request->wasPosted() + ) { return false; } -- 2.20.1